Add a hreftranslate attribute #3870
Conversation
|
@domenic PTAL |
There was a problem hiding this comment.
Generally looks good! Some small suggestions on ways to make things clearer, and one question around the IDL attribute casing.
And of course still needs multi-implementer interest before we can merge, but it's great to have the proposed semantics formalized and written down.
source
Outdated
| @@ -19435,6 +19436,7 @@ interface <dfn>HTMLAnchorElement</dfn> : <span>HTMLElement</span> { | |||
| [<span>CEReactions</span>] attribute DOMString <span data-x="dom-a-rel">rel</span>; | |||
| [SameObject, PutForwards=<span data-x="dom-DOMTokenList-value">value</span>] readonly attribute <span>DOMTokenList</span> <span data-x="dom-a-relList">relList</span>; | |||
| [<span>CEReactions</span>] attribute DOMString <span data-x="dom-a-hreflang">hreflang</span>; | |||
| [<span>CEReactions</span>] attribute DOMString <span data-x="dom-a-hreftranslate">hreftranslate</span>; | |||
There was a problem hiding this comment.
Hmm. Normally the IDL attribute should be camel-cased, hrefTranslate. But for some reason hreflang is not. Unsure which type of consistency we should side with... I'm OK with hreftranslate as the default, unless others have thoughts to the contrary.
There was a problem hiding this comment.
I made it hrefTranslate it seems not to deviate from the rest of the examples no?
domenic
added
addition/proposal
dtapuska
force-pushed
the
href_translate
branch
from
410c539
to
6b35912
Compare
annevk
added
the
needs tests
|
I still have strong migivings about his attribute and what it is meant to do. Please see #2945 (comment) |
dtapuska
force-pushed
the
href_translate
branch
from
afbb8cc
to
dba282f
Compare
sideshowbarker
added
the
impacts documentation
|
Potential documentation need recorded on MDN content roadmap at https://trello.com/c/CGD3jgk5/128-add-a-hreftranslate-attribute |
dtapuska
force-pushed
the
href_translate
branch
from
dba282f
to
91bcb32
Compare
Proposal from https://github.com/dtapuska/html-translate Fixes 2945
- Adjust IDL to be camelcase - Add example - Remove supported text around content attribute
- Fix typo s/nativating/navigating - Add cross references for attributes - Fix translate typo
dtapuska
force-pushed
the
href_translate
branch
from
91bcb32
to
c781516
Compare
dtapuska
force-pushed
the
href_translate
branch
from
c781516
to
5ac10f5
Compare
Proposal from https://github.com/dtapuska/html-translate
Fixes #2945
💥 Error: Wattsi server error 💥
PR Preview failed to build. (Last tried on Jan 15, 2021, 7:58 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.