Revert 'Clarify that media="" and lang="" affect manifest selection' #6502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ad3b7e6 as it did not have multi-implementer support or tests. See #6444 (comment) for context.
|
Ok with me. Gives us a bit of time to get agreement. Might also be nice to see if we can get the WebKit folks to comment too. |
domenic
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Happy to revert since apparently it was merged incorrectly, but I'll note that this leaves us in a more incoherent state due to https://html.spec.whatwg.org/#processing-the-media-attribute . That's why the original PR was "clarify that they apply" and not "make them apply".
|
Yeah, that language does seem unfortunate and seems wrong for other types as well, e.g., modulepreload. I also wonder if some types do not fit into either hyperlink or resource, e.g., dns-prefetch and preconnect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ad3b7e6 as it did not have multi-implementer support or tests. See #6444 (comment) for context.
cc @marcoscaceres @beaufortfrancois @yoavweiss
/links.html ( diff )