Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include MusicBrainz Release ID in the log file #381

Closed
srussel opened this issue Mar 16, 2019 · 3 comments
Closed

Include MusicBrainz Release ID in the log file #381

srussel opened this issue Mar 16, 2019 · 3 comments
Assignees
@Freso
Labels
Accepted Accepted issue on our roadmap Feature New feature Improvement Minor improvement to code Priority: low Low priority
Milestone
0.8.0

Comments

@srussel
Copy link

srussel commented Mar 16, 2019

It would be useful to include the MusicBrainz Release ID and lookup url in the log file similar to what currently done with the Disc ID. I would like to be able to know which release id was used for the metadata in the case of multiple matches and be able to easily look it up in MB in case I need to correct any details.
@Freso Freso added Priority: low Low priority Improvement Minor improvement to code Feature New feature Needed: patch A pull request is required labels Mar 16, 2019
@Freso Freso self-assigned this Mar 16, 2019
@Freso Freso mentioned this issue Mar 16, 2019
Merged
@Freso Freso added Status: in progress Issue/pull request which is currently being worked on and removed Needed: patch A pull request is required labels Mar 16, 2019
@Freso
Copy link
Member

Freso commented Mar 16, 2019

Can you take a look at #382 and see if that looks like what you’re requesting? :)

Freso added a commit that referenced this issue Mar 16, 2019
@Freso
Include MusicBrainz Release URL in log output
a758ea5 
This also passes *all* metadata to the `result` object, giving loggers a
lot more (release) metadata to work with, in case custom, “3rd party”
loggers (or even ourselves in the future!) want to do something more
fancy or expansive with the metadata in the log file.

Fixes #381

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
@srussel
Copy link
Author

srussel commented Mar 17, 2019

Looking at the sample log output in #382, yes that is exactly what I am looking for. Thanks for the quick patch.

@Freso Freso added this to the 0.8.0 milestone Mar 17, 2019
JoeLametta pushed a commit that referenced this issue Mar 18, 2019
@Freso @JoeLametta
Include MusicBrainz Release URL in log output (#382)
135cc9c 
* Include MusicBrainz Release URL in log output

This also passes *all* metadata to the `result` object, giving loggers a
lot more (release) metadata to work with, in case custom, “3rd party”
loggers (or even ourselves in the future!) want to do something more
fancy or expansive with the metadata in the log file.

Fixes #381

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>

* Uppercase "url" in output: "URL"

Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
@JoeLametta
Copy link
Collaborator

Just merged it in the develop branch. It will land in whipper's next release.

@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap and removed Status: in progress Issue/pull request which is currently being worked on labels Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Freso Freso

Labels
Accepted Accepted issue on our roadmap Feature New feature Improvement Minor improvement to code Priority: low Low priority
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
3 participants
@Freso @JoeLametta @srussel