Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_result_logger.py: truly test all four cases of whipper version scheme #427

Closed
JoeLametta opened this issue Dec 3, 2019 · 0 comments · Fixed by #456
Closed

test_result_logger.py: truly test all four cases of whipper version scheme #427

JoeLametta opened this issue Dec 3, 2019 · 0 comments · Fixed by #456
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: tests Tests are required Priority: low Low priority Stretch Optional goal for the current sprint (may not be delivered)
Milestone
1.0

Comments

@JoeLametta
Copy link
Collaborator

From Freso's comment:

This test doesn’t actually test all four cases though, it just makes the current .log file not break. We should have 3 additional .log files in addition to test_result_logger.log which the version string being formatted differently in each and test each of those. (Or have a separate function to test the version string so we could unit test it with values directly, without having to parse a whole .log file…)
@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Priority: low Low priority Improvement Minor improvement to code Needed: tests Tests are required labels Dec 3, 2019
JoeLametta referenced this issue Dec 3, 2019
@JoeLametta
Whipper's version RegEX: support all valid scheme cases
d5bf83e 
Initial work by ArchangeGabriel: #421

Fixes #420.

Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
@JoeLametta JoeLametta added the Stretch Optional goal for the current sprint (may not be delivered) label Dec 3, 2019
@JoeLametta JoeLametta added this to the 1.0 milestone Dec 3, 2019
@ABCbum ABCbum mentioned this issue Jan 24, 2020
Merged
JoeLametta pushed a commit to ABCbum/whipper that referenced this issue Jan 29, 2020
@JoeLametta
Test all four cases of whipper version schemes
f59caea 
Group different version schemes with the actual one generated from the logger in a list to avoid parsing a whole .log file.
The four possible cases are documented here: https://github.com/pypa/setuptools_scm/#default-versioning-scheme.

Fixes: whipper-team#427.

Signed-off-by: ABCbum <kimlong221002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: tests Tests are required Priority: low Low priority Stretch Optional goal for the current sprint (may not be delivered)
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Test all four cases of whipper version scheme ABCbum/whipper
1 participant
@JoeLametta