Fix division by zero

[sqozz]

reads can be zero sometimes an will then cause a ZeroDivisionError in the changed line.
This can happen after calling:
$ whipper offset find

[Freso]

This doesn't seem very Pythonic to me. Something like

if reads:
    return min(…)
else:
    return 0

looks better to me. Or maybe even just assigning to a variable:

quality = 0
if reads:
    quality = min(frames * 2.0 / reads, 1.0)
return quality

[sqozz]

Actually I thought about this and wanted to preserve this beauty of code with only one return path (and the min()). If you ask me the most pythonic is to ask for forgiveness and not permission. So what about a try-expect block that catches the division by zero exception?

[JoeLametta]

BTW, I haven't checked: is it OK to have reads with a value of 0? (is there any underlying bug?)

[sqozz]

Most likely my CD drive was somewhat broken because I didn't even managed to rip one single CD with it but regardless of that; whipper should catch it IMHO.
In the long run one could think about throwing actual error messages if the drive operates weird (like here).

[JoeLametta]

If that's the reason, I think it's better to rely on the try ... except solution for that's more expressive in this case (unexpected error).

[JoeLametta]

Please rewrite it using a try ... except

[bb010g]

Can this be merged now?

[sqozz]

At least nothing to add from my side

[JoeLametta]

At least nothing to add from my side

Merged, thanks.

[RecursiveForest]

I would actually request this be un-merged and reviewed for why there's a division by zero happening before we decide to just eat the error.

[sqozz]

@RecursiveForest this is just a fix for a progress indicator which caused whipper to fully crash. It does not influence the rips…
But to answer your question: A division by zero happens here because cdparanoia returns 0 bytes as result which happened most likely because of a faulty CD drive.