Fix recently introduced Python 3 incompatibility #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LingMan Sorry, I don't understand what's the purpose of this PR: even though whipper is going to be ported to Python 3 in the future (#78), right now it only supports Python 2.7. The proposed PR surely isn't enough to make it Python 3 compatible... could you better explain its rationale? Thanks, |
|
You're absolutely right, it doesn't make it Python 3 compatible. I just noticed the breakage while looking at the diff and saw no reason to hold off a fix. Especially considering that all the other prints in that file already use (), which makes this instance easy to miss. |
|
@LingMan Understood. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes d4aad57