Clarify format option for disc template #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous text implied to me that this was the sort name for the Album/Disc title. Not the artist sort name.
|
💖 Thanks for opening your first pull request here! 💖 |
JoeLametta
approved these changes
Jan 17, 2019
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
Sorry, I was tired and noticed that this pull request was based on master only after the merge. Won't revert it but next time please use the Thanks, |
|
Will do. Thanks! Maybe my first pull request on develop can be adding some
branching information to the readme ;)
…On Thu, Jan 17, 2019 at 2:13 PM JoeLametta ***@***.***> wrote:
Sorry, I was tired and noticed that this pull request was based on master
only after the merge. Won't revert it but next time please use the develop
branch as base for all the pull requests.
Thanks,
JoeLametta
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#353 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABIdJrUqgMoP7fYzMwO5E5kMS88xID7_ks5vEPVxgaJpZM4Z9hhj>
.
|
👍 Yeah, maybe you can expand what's written in this section. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous text implied to me that this was the sort name for the Album/Disc title. Not the artist sort name.