Specify supported version(s) of Python in setup.py #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for dropping Python 2.7 support[1], this specifies versions that *are* compatible with Python 2.7, so anyone installing via pip (if we end up publishing to PyPI) will get the proper version. See https://packaging.python.org/guides/dropping-older-python-versions/ [1] #78 Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
Freso
force-pushed
the
specify-python-support
branch
from
b5bb330
to
a9bb51a
Compare
|
Looks good to me. |
|
@MerlijnWajer gave the go ahead to pull this into "develop" on IRC, so went ahead and did just that. |
pombredanne
added a commit
to aboutcode-org/scancode-toolkit
that referenced
this pull request
Mar 6, 2019
Based on @Freso PR at: whipper-team/whipper#378 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for dropping Python 2.7 support, this specifies versions that are compatible with Python 2.7, so anyone installing via pip (if we end up publishing to PyPI) will get the proper version.
See https://packaging.python.org/guides/dropping-older-python-versions/