Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grab cover art from MusicBrainz/Cover Art Archive and add it to the resulting whipper rips #436

Merged
merged 3 commits into from
Jan 14, 2020
Merged

Grab cover art from MusicBrainz/Cover Art Archive and add it to the resulting whipper rips #436

merged 3 commits into from
Jan 14, 2020

Commits on Jan 14, 2020

  1. Support fetching cover art images from the Cover Art Archive 

    Add option `--cover-art` to `whipper cd rip` command which accepts three values:
- `file`: save the downloaded cover image as standalone file in the rip folder (named `cover.jpg`)
- `embed`: embed the download cover image into all the ripped audio tracks (no standalone file will be kept)
- `complete`: save standalone cover image as standalone file and embed it into all the ripped audio tracks (`file` + `embed`)

Every cover art is fetched from the Cover Art Archive as JPEG thumbnail with a maximum dimension of 500px.
Other supported values for the thumbnails are 250, 500 and 1200 (currently only some images have a corresponding 1200px sized thumbnail).

This feature introduces an optional dependency on the `Pillow` module which is required for the decoding of the cover file (required by the `embed` and `complete` option values).

Problem:
- EmbedPicTureTask shouldn't be a task.

Signed-off-by: ABCbum <kimlong221002@gmail.com>
Co-authored-by: JoeLametta <JoeLametta@users.noreply.github.com>
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
    @JoeLametta
    ABCbum and JoeLametta committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    f61214a View commit details
    Browse the repository at this point in the history

  2. Update README, dependencies and supporting files for cover art feature 

    Signed-off-by: ABCbum <kimlong221002@gmail.com>
Co-authored-by: JoeLametta <JoeLametta@users.noreply.github.com>
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
    @JoeLametta
    ABCbum and JoeLametta committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    8181cac View commit details
    Browse the repository at this point in the history

  3. Add test case to check getCoverArt's functionality 

    Mock two functions `getCoverArt`, `get_image_front` and use
a locally available cover art to check if the created cover
art exists.

Problems:
- How to check image's quality.
- Not sure if only this check is enough (do we need to check the
embedding part?).

Signed-off-by: ABCbum <kimlong221002@gmail.com>
    @JoeLametta
    ABCbum authored and JoeLametta committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    e2942b0 View commit details
    Browse the repository at this point in the history