Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeBSD to CI #240

Merged
merged 4 commits into from
May 21, 2020
Merged

Add FreeBSD to CI #240

merged 4 commits into from
May 21, 2020

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented May 20, 2020

TravisCI supports FreeBSD nowadays. Let's see how well it works.

  • Only libusb is supported, so it won't regress anymore
  • Deployment is not implemented because why bother given downstream package

@whoozle
Copy link
Owner

whoozle commented May 20, 2020

Thanks!
Is it possible to add readline library to this PR?

@jbeich
Copy link
Contributor Author

jbeich commented May 20, 2020

readline seems like a bug, investigating. I also need to add pybind11 dependency.

.travis.yml Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
cli/CMakeLists.txt Outdated Show resolved Hide resolved
-- Found Readline: /usr/local/include
-- Performing Test READLINE_NO_CURSES_TEST
-- Performing Test READLINE_NO_CURSES_TEST - Failed
-- readline test failed - some systems expect you to link with termcap or curses libraries
-- please find an example there: https://bugzilla.redhat.com/show_bug.cgi?id=499837
-- trying to find and link curses library...
-- Found Curses: /usr/lib/libcurses.so
-- Performing Test READLINE_CURSES_TEST
-- Performing Test READLINE_CURSES_TEST - Failed
CMake Warning at cli/CMakeLists.txt:46 (message):
  no readline library found, using stub

/usr/bin/cc  -DREADLINE_NO_CURSES_TEST -fPIE -o CMakeFiles/cmTC_2e5b8.dir/src.c.o   -c src.c
src.c:3:10: fatal error: 'readline/readline.h' file not found
 #include <readline/readline.h>
          ^~~~~~~~~~~~~~~~~~~~~

/usr/bin/c++  -DHAVE_LIBMAGIC -DMTPZ_ENABLED -DUSB_BACKEND_LIBUSB -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE=1 -I../ -I../mtp/backend/posix -I../mtp/backend/libusb -isystem ../cli/Readline_INCLUDE_DIR -O3 -DNDEBUG -fPIE   -Wall -pthread -std=gnu++11 -MD -MT cli/CMakeFiles/aft-mtp-cli.dir/CommandLine.cpp.o -MF cli/CMakeFiles/aft-mtp-cli.dir/CommandLine.cpp.o.d -o cli/CMakeFiles/aft-mtp-cli.dir/CommandLine.cpp.o -c ../cli/CommandLine.cpp
../cli/CommandLine.cpp:26:10: fatal error: 'readline/readline.h' file not found
 #include <readline/readline.h>
          ^~~~~~~~~~~~~~~~~~~~~
-- Looking for include file pybind11/pybind11.h
-- Looking for include file pybind11/pybind11.h - not found
CMake Warning at CMakeLists.txt:64 (message):
  pybind11 not found, skipping python bindings

/usr/bin/c++   -I/usr/local/include/python3.7m -fPIE -o CMakeFiles/cmTC_43052.dir/pybind11_FOUND.cpp.o -c build/CMakeFiles/CheckIncludeFiles/pybind11_FOUND.cpp
build/CMakeFiles/CheckIncludeFiles/pybind11_FOUND.cpp:2:10: fatal error: 'pybind11/pybind11.h' file not found
 #include <pybind11/pybind11.h>
          ^~~~~~~~~~~~~~~~~~~~~
@whoozle whoozle merged commit 019c052 into whoozle:master May 21, 2020
@whoozle
Copy link
Owner

whoozle commented May 21, 2020

Thank you for your work!

If you want more work on AFTL, you can try implementing direct FreeBSD backend without libusb. Libusb has serious limitations, at least at the time I started this project.

@whoozle
Copy link
Owner

whoozle commented May 21, 2020

there's API limitation, not only bugs, e.g. you have to provide full data for bulk transfer in memory, limitations in description parsing, etc etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants