This repository has been archived by the owner on May 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Infinite requests for local storage on Safari #126
Comments
Hrm... yeah, the reason that's happening over and over again is because this... https://github.com/whosonfirst/js-mapzen-whosonfirst/blob/master/src/mapzen.whosonfirst.net.js ...if fetching lots of files and not being smart about not invoking the cache/localforage hooks after they've been denied the first time. |
Check for this and disable further cache sets if true...
|
thisisaaronland
pushed a commit
that referenced
this issue
Aug 31, 2017
…te everything that uses localforage to use a generic WOF cache wrapper for disabling things across the board...
thisisaaronland
pushed a commit
that referenced
this issue
Sep 1, 2017
thisisaaronland
pushed a commit
that referenced
this issue
Sep 1, 2017
…ms to work but needs some more testing
dphiffer
added a commit
that referenced
this issue
Oct 2, 2017
… to update everything that uses localforage to use a generic WOF cache wrapper for disabling things across the board..." This reverts commit 04525dd.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Encountered on macOS 10.12.6, Safari 10.1.2
To reproduce, navigate to a page in the Spelunker on Safari, following a link such as: https://whosonfirst.mapzen.com/spelunker/brands/420574927/. You must be visiting it for the first time in this browser or have cleared storage preferences for the domain (Safari -> Preferences -> Privacy -> Manage Website Data... -> mapzen.com -> Remove).
You should encounter an alert like this:
![screen shot 2017-08-31 at 2 24 33 pm](https://user-images.githubusercontent.com/3371850/29946554-a7e8b704-8e5a-11e7-9783-bb76d291870e.png)
If you click "Don't Allow", the alert is immediately recreated. While the alert is shown, you cannot close tabs, change settings, open a developer console, or quit Safari. The browser is locked until you agree to allow however much local storage the page needs.
I think this alert is only triggered when a page requests more than 5MB of storage, so maybe this is do to a recent change in the local storage usage? Whatever the cause, can we let the page fail in this case rather than locking the whole browser?
The text was updated successfully, but these errors were encountered: