Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Allow ignoring missing translations of blank source messages #74

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

catrope
Copy link
Contributor

@catrope catrope commented Jul 30, 2019

For the requireCompleteTranslationLanguages and
requireCompleteTranslationMessages features, it doesn't make sense to
fail when a message whose source text is blank doesn't have a
translation. These messages aren't intended to be translated, and even
if they were translated as blanks, that would also fail because
disallowBlankTranslations is true by default.

This adds ignoreMissingBlankTranslations and sets it to true by default.
If enabled, a message is only considered missing if its source text is
non-empty. Blank source message do still require documentation.

@Krinkle
Copy link
Member

Krinkle commented Jul 30, 2019

This sounds good to me. Another option might be to implement support for the {{Ignore}} and {{Optional}} conventions from our translation community (as placed in qqq), and then based on that ignore existence validation for translations.

The option for that could be enabled for default and act across things that would otherwise relate to disallowBlankTranslations and requireCompleteTranslationLanguages, which might be more user-friendly long-term.

Thoughts? (see also #69)

For the requireCompleteTranslationLanguages and
requireCompleteTranslationMessages features, it doesn't make sense to
fail when a message whose source text is blank doesn't have a
translation. These messages aren't intended to be translated, and even
if they were translated as blanks, that would also fail because
disallowBlankTranslations is true by default.

This adds ignoreMissingBlankTranslations and sets it to true by default.
If enabled, a message is only considered missing if its source text is
non-empty. Blank source message do still require documentation.
@jdforrester jdforrester merged commit 7af3579 into wikimedia:master Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants