common: Enable no-constant-binary-expression (#464)

wikimedia · Apr 27, 2022 · ad700b7 · ad700b7
1 parent 0296003
commit ad700b7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/common.json b/common.json
@@ -57,6 +57,7 @@
 		"no-array-constructor": "error",
 		"no-bitwise": "error",
 		"no-caller": "error",
+		"no-constant-binary-expression": "error",
 		"no-constant-condition": [ "error", { "checkLoops": false } ],
 		"no-empty": [ "error", { "allowEmptyCatch": true } ],
 		"no-eval": "error",

diff --git a/test/fixtures/common/invalid.js b/test/fixtures/common/invalid.js
@@ -62,8 +62,11 @@ var APP;
 		// eslint-disable-next-line no-tabs
 		name = options.bar ? upHere( id ) : id; //	Wow!
 
+		// eslint-disable-next-line no-constant-binary-expression
+		name = options.bar ? 'truthy' : 'alsoTruthy' || 3;
+
 		// eslint-disable-next-line no-constant-condition
-		if ( true || options.quux ) {
+		if ( true ) {
 			name += options.quux;
 		// eslint-disable-next-line dot-notation, computed-property-spacing
 		} else if ( options['default' ] ) {