Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vue: Assert upstream config settings #420

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

vue: Assert upstream config settings #420

wants to merge 2 commits into from

Conversation

edg2s
Copy link
Member

@edg2s edg2s commented Nov 2, 2021

This is useful when upstream changes.

@edg2s
vue: Assert upstream config settings
2807a53 
This is useful when upstream changes.
@edg2s
Copy link
Member Author

edg2s commented Nov 2, 2021

TODO: There are >60 rules to add to invalid.vue

@jdforrester
Copy link
Member

Oh right, your TODO is a TODO-before-merge. :-)

@edg2s edg2s requested a review from catrope November 3, 2021 16:24
@edg2s
Copy link
Member Author

edg2s commented Nov 3, 2021

Oh right, your TODO is a TODO-before-merge. :-)

Yeah - maybe @catrope will have a go when he's bored, because he understands these rules better than me so could write better tests.

@edg2s
Copy link
Member Author

edg2s commented Nov 4, 2021

As this only for tests, it needn't block the release.

@jdforrester jdforrester mentioned this pull request May 17, 2022
Closed
20 tasks
@edg2s edg2s changed the base branch from master to main July 27, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catrope catrope Awaiting requested review from catrope

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edg2s @jdforrester