Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Add stylelint- comments to max-len ignorePattern #448

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

catrope
Copy link
Contributor

@catrope catrope commented Feb 9, 2022

Lines with // eslint-disable comments are already ignored.
However, in .vue files, ESLint runs the max-len rule against
the <style> block too for some reason, so it complains about
line lengths for stylelint-disable comments.

Add stylelint- to the regex for disabling max-len, so that we don't
complain about stylelint-disable comments being too long.

Lines with // eslint-disable comments are already ignored.
However, in .vue files, ESLint runs the max-len rule against
the <style> block too for some reason, so it complains about
line lengths for stylelint-disable comments.

Add stylelint- to the regex for disabling max-len, so that we don't
complain about stylelint-disable comments being too long.
@Volker-E Volker-E self-requested a review February 9, 2022 11:22
Volker-E
Volker-E previously approved these changes Feb 9, 2022
edg2s
edg2s previously requested changes Feb 9, 2022
Copy link
Member

@edg2s edg2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test case

@jdforrester jdforrester merged commit 2cc74a6 into master Feb 9, 2022
@jdforrester jdforrester deleted the max-len-ignore-stylelint branch February 9, 2022 17:48
@jdforrester jdforrester mentioned this pull request May 17, 2022
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants