Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediawiki: Upgrade eslint-plugin-mediawiki to v0.4.0 #469

Merged
merged 3 commits into from
Jul 28, 2022

Conversation

jdforrester
Copy link
Member

  • New rule: no-nodelist-unsupported-methods (Ed Sanders)
  • New rule: no-extended-unicode-identifiers (Roan Kattouw)
  • Rule fix: msg-doc: Fix short URL to rule help page (Sam Wilson)
  • Rule fix: class-doc: Fix linting of classList.toggle (Ed Sanders)

@jdforrester jdforrester requested a review from edg2s May 21, 2022 13:51
@jdforrester jdforrester mentioned this pull request May 21, 2022
20 tasks
edg2s
edg2s previously requested changes May 23, 2022
Copy link
Member

@edg2s edg2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to enable the new rules as there is no preset config (maybe there should an "all" config).

* New rule: `no-nodelist-unsupported-methods` (Ed Sanders)
* New rule: `no-extended-unicode-identifiers` (Roan Kattouw)
* Rule fix: `msg-doc`: Fix short URL to rule help page (Sam Wilson)
* Rule fix: `class-doc`: Fix linting of classList.toggle (Ed Sanders)
@jdforrester jdforrester force-pushed the eslint-plugin-mediawiki-0.4.0 branch from 2d4e193 to f99e255 Compare May 31, 2022 14:27
@jdforrester jdforrester requested a review from edg2s May 31, 2022 14:27
@catrope catrope merged commit 946fd15 into master Jul 28, 2022
@edg2s edg2s deleted the eslint-plugin-mediawiki-0.4.0 branch July 30, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants