Skip to content

Commit

Permalink
No longer omit stdlib dependencies from dependency inference.
Browse files Browse the repository at this point in the history
Omitting these packages would break backport libraries (such as dataclasses). Performance impact is negligible since the dependency graph has already been gathered.

Benchmarks using `$ hyperfine --warmup=1 --runs=10 './pants --no-remote-cache-{read,write} --no-pantsd dependencies ::'`
Before these changes (omitting stdlib dependencies):
```bash
Benchmark pantsbuild#1: ./pants --no-remote-cache-{read,write} --no-pantsd dependencies ::
  Time (mean ± σ):      8.852 s ±  0.105 s    [User: 8.612 s, System: 5.314 s]
  Range (min … max):    8.702 s …  9.107 s    10 runs
```

After changes (with stdlib dependency inference)
```bash
Benchmark pantsbuild#1: ./pants --no-remote-cache-{read,write} --no-pantsd dependencies ::
  Time (mean ± σ):      8.854 s ±  0.123 s    [User: 8.619 s, System: 5.333 s]
  Range (min … max):    8.682 s …  9.111 s    10 runs
```

[ci skip-rust]
[ci skip-build-wheels]
  • Loading branch information
williamscs committed Sep 9, 2021
1 parent 567ece2 commit 3522488
Show file tree
Hide file tree
Showing 9 changed files with 2 additions and 1,166 deletions.

This file was deleted.

Empty file.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 3522488

Please sign in to comment.