Skip to content

Commit

Permalink
stagefright aacenc: Don't address a Word32 with a Word16 pointer
Browse files Browse the repository at this point in the history
Currently, a pointer to a Word32 is used as a pointer to Word16, which
doesn't work as intended on big endian architectures.

This change needs to be analyzed and tested properly so that it doesn't
cause issues with overflows in these variables. Another solution would be
to change all the scf arrays to 32 bit instead.

Change-Id: I53d9eb83bdaf8d3b1530eb5064dd10b08bce737a
  • Loading branch information
mstorsjo committed Jan 13, 2012
1 parent b4cee0f commit 51a50f0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion media/libstagefright/codecs/aacenc/src/sf_estim.c
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ static void assimilateSingleScf(PSY_OUT_CHANNEL *psyOutChan,
Word16 *minScfCalculated,
Flag restartOnSuccess)
{
Word32 sfbLast, sfbAct, sfbNext, scfAct, scfMin;
Word16 sfbLast, sfbAct, sfbNext, scfAct, scfMin;
Word16 *scfLast, *scfNext;
Word32 sfbPeOld, sfbPeNew;
Word32 sfbDistNew;
Expand Down

0 comments on commit 51a50f0

Please sign in to comment.