Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 12.0.3 - NgxSkeletonLoaderComponent` need to receive 'appearance' as: circle or empty string. Forcing default to "''" #79

Closed
BruneXX opened this issue Jun 4, 2021 · 1 comment

Comments

@BruneXX
Copy link

BruneXX commented Jun 4, 2021

**I'm submitting a ...

  • [x ] bug report => since angular update to v12

Current behavior

Following error appears using angular v12:
NgxSkeletonLoaderComponent need to receive 'appearance' as: circle or empty string. Forcing default to "''"

Expected behavior
No errors using the library with latest angular verison

Reproduction of the problem
Just install Angular 12 and ngx-skeleton-loader

What is the motivation / use case for changing the behavior?
Update the library to be compatible with Angular v12

Please tell us about your environment:

  • Debian Linux
  • Chrome latest (90.x)
  • Angular 12.0.3
  • Node 14.17.0
  • Npm 7.16.0
  • Language: TypeScript 4.x
BruneXX added a commit to BruneXX/ngx-skeleton-loader that referenced this issue Jun 4, 2021
The aim of this fix is to fix recently reported issue willmendesneto#79
please review and if it's ok and you can release a new version will be awesome.
@willmendesneto
Copy link
Owner

Hi @BruneXX .

As mentioned in this pull request #80 (comment), this is not a blocker for Angular v12. The issue you're facing is related to a misconfiguration (there's no line appearance on the module at the moment) and Angular v12 has some strict rules that got your app affected by that.

So I'm closing this issue at the moment. Thanks for raising that and for supporting this project <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants