Implemented 'features', and the 'look' feature, for the cameras. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 5, 2012 16:32
The current implementation generates a secondary list of camera objects, from the 'cameras' field, to expose. This results in in the client receiving two arrays: -- cameras: all camera instances related to the robot, and -- look_cameras: all cameras accessible to the 'look' feature of the app (a subset of 'cameras'). Note: the discrimination could also be done in the client, iterating over the 'cameras' array and the checking for the appropriate feature.
|
We needed a JS coding style for Robot Web Tools as well, so I just created a ROS JavaScript Coding Style Guide. There's already a ROS Python coding style. |
|
Oh, and thank you Brandon for the guides. I really needed something to use as quick reference. |
|
Thanks @etoccalino, this looks good! |
tlau
added a commit
that referenced
this pull request
Dec 6, 2012
Implemented 'features', and the 'look' feature, for the cameras.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
world.models.Camera instances which haven't got the "look" feature will not be displayed in the select widget of all cameras.