Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename var sshd -> sshd_config and debug output #299

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: rename var sshd -> sshd_config and debug output #299

wants to merge 8 commits into from

Conversation

mattwillsher
Copy link
Member

Enhancement:

Address role prefix on variable names.

Reason: Coding standards
Result:

Issue Tracker Tickets (Jira or BZ if any):

#297, #246

@mattwillsher mattwillsher marked this pull request as draft September 12, 2024 10:54
richm
richm reviewed Sep 12, 2024
View reviewed changes
tasks/main.yml Outdated Show resolved Hide resolved
@mattwillsher mattwillsher self-assigned this Sep 13, 2024
@mattwillsher mattwillsher marked this pull request as ready for review September 13, 2024 18:32
Jakuje
Jakuje approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not notice any issue. Maybe just a suggestion to provide some simple sanity test that the old name keeps working (ideally with both role and include_role syntax`).

@richm
Copy link
Collaborator

richm commented Sep 13, 2024

Did not notice any issue. Maybe just a suggestion to provide some simple sanity test that the old name keeps working (ideally with both role and include_role syntax`).

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jakuje Jakuje Jakuje approved these changes

@richm richm Awaiting requested review from richm

Assignees

@mattwillsher mattwillsher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattwillsher @richm @Jakuje