Update the prototype of NtCreateIRTimer #2105
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to my reverse engineering results, the pseudocode
of NtCreateIRTimer syscall is as follows:
NTSTATUS NtCreateIRTimer(PHANDLE TimerHandle, LPVOID Reserved, ACCESS_MASK DesiredAccess)
{
return NtCreateTimer2(TimerHandle, Reserved, 0, 2, DesiredAccess);
}
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
dmex
requested changes
Jun 26, 2024
phnt/include/ntexapi.h
Outdated
| @@ -721,6 +721,7 @@ NTSTATUS | |||
| NTAPI | |||
| NtCreateIRTimer( | |||
| _Out_ PHANDLE TimerHandle, | |||
| _In_ LPVOID Reserved, | |||
There was a problem hiding this comment.
- LPVOID needs to be PVOID
PVOID Reservedwould beHANDLE IRTimerHandleon Windows 10 and 11?
There was a problem hiding this comment.
According to my reverse engineering, the semantics of this parameter is different between Windows 10 and Windows 11:
On Windows 10, it should be zero, or NtCreateTimer2 will return 0xc00000f0.
On Windows 11, NtCreateTimer2 adds some compartion for Attributes parameter, so this Reserved could be a user mode pointer.
(not 100% sure... anyway, keep it as PVOID may be OK?)
There was a problem hiding this comment.
I'll dig deeper into this when I have time... sorry for the inconvenience this hastily-made PR has caused you.
dmex
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to my reverse engineering results, the pseudocode
of NtCreateIRTimer syscall is as follows: