[fix] Clone enumerable AND non-enumerable Error properties when cloning.

winstonjs · Oct 29, 2015 · 73890ac · 73890ac
1 parent ec8afd5
commit 73890ac
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/winston/common.js b/lib/winston/common.js
@@ -86,9 +86,9 @@ exports.clone = function (obj) {
     // With potential custom Error objects, this might not be exactly correct,
     // but probably close-enough for purposes of this lib.
     copy = new Error(obj.message);
-    for (var i in obj) {
-      copy[i] = obj[i];
-    }
+    Object.getOwnPropertyNames(obj).forEach(function (key) {
+      copy[key] = obj[key];
+    });
 
     return copy;
   }