Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File-Transport should be using the operating systems end of line, not the Unix one, by default. #583

Closed
wants to merge 1 commit into from

Conversation

Mik13
Copy link

@Mik13 Mik13 commented Mar 20, 2015

I don't see any advantages, if the file-transport logs with '\n' by default. It would make more sense, if it uses the OS EOLs if none is explicitly specified.

@indexzero
Copy link
Member

Thanks! Cherry-picked. Will go into winston@1.0.0 which will be published shortly 👍

@indexzero indexzero closed this Apr 7, 2015
indexzero added a commit that referenced this pull request Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants