Update file.js - objectMode writable stream #632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appending this.eol explicitly to the result that common.log returns makes the output always become a string. That eliminates the possibility of piping js objects to the writable stream (which could be extremely handy for some cases). The proposed change won't break the code as the only case for the output not to be an object would be if this.stringify is explicitly rewritten to return objects (i.e. transport.stringify = function(obj){return obj})
|
I am +1 on this. Could you add some tests? |
indexzero
added
the
Feature Request
indexzero
added a commit
that referenced
this pull request
Oct 29, 2015
|
Fixed in 79ba840 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appending this.eol explicitly to the result that common.log returns makes the output always become a string. That eliminates the possibility of piping js objects to the writable stream (which could be extremely handy for some cases). The proposed change won't break the code as the only case for the output not to be a string would be if this.stringify is explicitly rewritten to return objects (i.e. transport.stringify = function(obj){return obj})