fix: websocket not receiving messages after some time #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #791 +/- ##
=============================================
- Coverage 58.44% 58.29% -0.15%
Complexity 666 666
=============================================
Files 431 432 +1
Lines 11138 11170 +32
Branches 1122 1122
=============================================
+ Hits 6510 6512 +2
- Misses 4150 4180 +30
Partials 478 478 |
|
Labeler is currently broken: srvaroa/labeler#43. Seems to be caused by: niemeyer/gopkg#63 |
alexandreferris
approved these changes
Aug 15, 2022
vitorhugods
deleted the
fix/websocket_not_receiving_messages_after_some_time
branch
MohamadJaara
added a commit
that referenced
this pull request
Aug 16, 2022
* fix: websocket not receiving messages after some time * chore: reduce ping interval to 20s Co-authored-by: Mohamad Jaara <mohamad.jaara@wire.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
After some time, the websocket dies. It completely stops receiving messages without any sings of errors, exceptions, or anything else being called.
Causes
As we do not send messages to the backend, it seems that the backend expects at least some pings every so often to keep the connection alive.
After some time without receiving anything, the backend just leaves the connection in a limbo and doesn't send any more messages through it.
Solutions
Add a ping every so many seconds.
It seems that @makingthematrix also went through this problem back in 2019 for the Scala app (see this commit), and 30s has been the magic number that carried the Scala app until now.
Unfortunately OkHttp doesn't handle dynamic pinging, so it must be configured directly into the HttpEngine, and it seems that the configuration in WebSockets is just ignored if you're using OkHttp.
So, even though adding it to OkHttp fixes it for Android and JVM, I've added it to Ktor as well so it also works for other platforms.
Testing
Manually tested as we can't yet mock WebSockets using Ktor.
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.