Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not returning a promise when initializing the SDK #12

Merged
merged 7 commits into from
Feb 1, 2018
Merged

Conversation

somentelucas
Copy link
Contributor

@somentelucas somentelucas commented Jan 29, 2018

  • Not returning a promise when initializing the SDK
  • Adding contributors to Readme
  • Removing test_dist/ need by using require syntax in tests

Fixes #11

@mbnakaya
Copy link

mbnakaya commented Jan 29, 2018

@somentelucas, e quanto ao build que falhou, no Travis CI?

@coveralls
Copy link

coveralls commented Jan 29, 2018

Pull Request Test Coverage Report for Build 134

  • 7 of 7 (100.0%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-7.8%) to 87.76%

Files with Coverage Reduction New Missed Lines %
dist/client/api.js 2 67.35%
Totals Coverage Status
Change from base Build 117: -7.8%
Covered Lines: 288
Relevant Lines: 300

💛 - Coveralls

@Igor-Lopes Igor-Lopes self-requested a review January 31, 2018 20:11
@somentelucas somentelucas merged commit af04b9b into develop Feb 1, 2018
@somentelucas somentelucas deleted the es6_2 branch February 1, 2018 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants