Fix: Type error on <Image /> component when strict TypeScript rules…

… are used with library type checking. (#10549) * hotfix:ts-explicit-error * add:changeset * update:changeset * Update .changeset/blue-dolls-melt.md Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev> * add:types-htmlattribute-extends * Update .changeset/blue-dolls-melt.md Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev> * Update blue-dolls-melt.md * addition: allow specifying null type --------- Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
withastro · Mar 26, 2024 · 54c2f97 · 54c2f97
1 parent c585528
commit 54c2f97
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/blue-dolls-melt.md b/.changeset/blue-dolls-melt.md
@@ -0,0 +1,5 @@
+---
+"astro": patch
+---
+
+Updates the `HTMLAttributes` type exported from `astro` to allow data attributes
diff --git a/packages/astro/types.d.ts b/packages/astro/types.d.ts
@@ -4,11 +4,14 @@ import type { Simplify } from './dist/type-utils.js';
 
 /** Any supported HTML or SVG element name, as defined by the HTML specification */
 export type HTMLTag = keyof astroHTML.JSX.DefinedIntrinsicElements;
+
 /** The built-in attributes for any known HTML or SVG element name */
 export type HTMLAttributes<Tag extends HTMLTag> = Omit<
 	astroHTML.JSX.IntrinsicElements[Tag],
 	keyof Omit<AstroBuiltinAttributes, 'class:list'>
->;
+> & {
+	[key: string]: string | number | boolean | null | undefined;
+};
 
 /**
  * All the CSS properties available, as defined by the CSS specification