Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add normalized comparison to check sessions (#396) #417

Merged
merged 1 commit into from
Apr 24, 2021

Conversation

dpalmasan
Copy link
Contributor

@dpalmasan dpalmasan commented Apr 10, 2021

First of all, thanks for this amazing tool, I started to use it recently (I come from the tox world)

This is a possible fix for (#396):

  • Attempt to do the previous checks
  • On fail, it will normalize arguments using ast (based on discussion)
  • The comparison will be on ast representation of the strings
  • Add unit tests

Copy link
Collaborator

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach a lot! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants