Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Improper Method Call: Replaced NotImplementedError #749

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Fixed Improper Method Call: Replaced NotImplementedError #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42101fc
Replaced `NotImplementedError` with `NotImplemented`
fazledyn-or Nov 16, 2023
b47fd02
Fix tests for #749
edgarrmondragon Dec 1, 2023
898260c
Merge pull request #2 from edgarrmondragon/edgarrmondragon/fix/749-test
fazledyn-or Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nox/_parametrize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def __eq__(self, other: object) -> bool:
elif isinstance(other, dict):
return dict(zip(self.arg_names, self.args)) == other

raise NotImplementedError
return NotImplemented
fazledyn-or marked this conversation as resolved.
Show resolved Hide resolved


def _apply_param_specs(param_specs: Iterable[Param], f: Any) -> Any:
Expand Down
3 changes: 1 addition & 2 deletions tests/test__parametrize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ def test_param_eq(param, other, expected):


def test_param_eq_fail():
with pytest.raises(NotImplementedError):
_parametrize.Param() == "a" # noqa: B015
assert _parametrize.Param() != "a"


def test_parametrize_decorator_one():
Expand Down