Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W.I.P: Add aws-cli-v2 #2272

Closed
wants to merge 1 commit into from
Closed

W.I.P: Add aws-cli-v2 #2272

wants to merge 1 commit into from

Conversation

Dentrax
Copy link
Member

@Dentrax Dentrax commented May 23, 2023

Fixes:

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • REQUIRED - The package is added to packages.txt

For security-related PRs

  • The security fix is recorded in advisories and secfixes

For version bump PRs

  • The epoch field is reset to 0
  • Patch source: patch source here

PTAL @tuananh

@Dentrax Dentrax requested a review from a team as a code owner May 23, 2023 20:09
@Dentrax Dentrax requested review from imjasonh and deitch May 23, 2023 20:09
@Dentrax Dentrax force-pushed the aws-cli-2 branch 2 times, most recently from 69e719a to 349cee9 Compare May 23, 2023 20:25
@Dentrax Dentrax changed the title Add aws-cli-v2 W.I.P: Add aws-cli-v2 May 23, 2023
Signed-off-by: Furkan <furkan.turkal@trendyol.com>
Co-authored-by: Batuhan <batuhan.apaydin@trendyol.com>
@Dentrax
Copy link
Member Author

Dentrax commented May 23, 2023

Hey @tuananh!

Should I include all the pip deps into environment.contents.packages? I'm wondering how you achieve success build without introducing required pip deps on aws-cli. 🤔

@tuananh
Copy link
Contributor

tuananh commented May 24, 2023

@Dentrax i have a poc repo here https://github.com/tuananh/aws-cli

yes, i did add all the dependencies for pip but it's like going down rabbit hole

there's also option to build with portable executable and i decided to go with that.

https://github.com/tuananh/aws-cli/blob/main/aws-cli.melange.yaml#L56

@Dentrax
Copy link
Member Author

Dentrax commented May 24, 2023

This is nice @tuananh

I had to do more stuff than I thought. Do you want to take over this? I can close this one since yours ready to ship. 🚀

@tuananh
Copy link
Contributor

tuananh commented May 24, 2023

This is nice @tuananh

I had to do more stuff than I thought. Do you want to take over this? I can close this one since yours ready to ship. 🚀

it's very rough at the moment, i haven't worked out the proper dependency for each package yet.

I also don't have capacity to do this at submit a PR during this time.

I did my first PR for aws-cli here #1848 You can add the rest to this PR and clean it up :)

@tuananh
Copy link
Contributor

tuananh commented May 24, 2023

also, it seems that we're not against using pip to install all these dependencies

https://github.com/wolfi-dev/os/blob/6d1a2c2df055810e78ca5b67bef9d8e4ae7c5b02/k8s-sidecar.yaml#LL35C20-L35C20

so maybe we don't need to port all of these PIP deps to wolfi?

@Dentrax Dentrax marked this pull request as draft July 10, 2023 18:01
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@rawlingsj
Copy link
Member

It looks like a bunch of dependencies have been added https://github.com/wolfi-dev/os/pull/4553/files. Is this PR still alive? I wonder if we can resurrect it?

@rawlingsj rawlingsj mentioned this pull request Oct 24, 2023
7 tasks
@tuananh
Copy link
Contributor

tuananh commented Oct 24, 2023

@rawlingsj I guess I can continue this later this week.

@tuananh
Copy link
Contributor

tuananh commented Oct 27, 2023

seems like there's already another PR for this as well #4555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants