-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
W.I.P: Add aws-cli-v2 #2272
W.I.P: Add aws-cli-v2 #2272
Conversation
69e719a
to
349cee9
Compare
Signed-off-by: Furkan <furkan.turkal@trendyol.com> Co-authored-by: Batuhan <batuhan.apaydin@trendyol.com>
Hey @tuananh! Should I include all the pip deps into |
@Dentrax i have a poc repo here https://github.com/tuananh/aws-cli yes, i did add all the dependencies for pip but it's like going down rabbit hole there's also option to build with portable executable and i decided to go with that. https://github.com/tuananh/aws-cli/blob/main/aws-cli.melange.yaml#L56 |
This is nice @tuananh I had to do more stuff than I thought. Do you want to take over this? I can close this one since yours ready to ship. 🚀 |
it's very rough at the moment, i haven't worked out the proper dependency for each package yet. I also don't have capacity to do this at submit a PR during this time. I did my first PR for aws-cli here #1848 You can add the rest to this PR and clean it up :) |
also, it seems that we're not against using pip to install all these dependencies so maybe we don't need to port all of these PIP deps to wolfi? |
This Pull Request is stale because it has been open for 90 days with |
It looks like a bunch of dependencies have been added https://github.com/wolfi-dev/os/pull/4553/files. Is this PR still alive? I wonder if we can resurrect it? |
@rawlingsj I guess I can continue this later this week. |
seems like there's already another PR for this as well #4555 |
Fixes:
Related:
Pre-review Checklist
For new package PRs only
packages.txt
For security-related PRs
advisories
andsecfixes
For version bump PRs
epoch
field is reset to 0PTAL @tuananh