kserve - add kserve-storage-controller, run strip #27550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EyeCantCU
reviewed
Sep 4, 2024
EyeCantCU
previously approved these changes
Sep 4, 2024
based on https://github.com/kserve/kserve/blob/master/python/storage-initializer.Dockerfile Some notes: 1. storage-initializer says it is <3.12, so we're using 3.11 here. 2. we do not have python3.11 poetry, so a. let 'python3.11 -m pip' install poetry b. let that poetry to build a wheel c. install that wheel with 'python3.11 -m pip' 3. This _does_ use pip to install into the system path. There are lots of deps we already have that we could use, but for now let pip do it.
smoser
force-pushed
the
feature/kserve-storage-controller
branch
from
d849cf2
to
072ae99
Compare
|
With regard to the CVE scan failures:
|
EyeCantCU
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on
https://github.com/kserve/kserve/blob/master/python/storage-initializer.Dockerfile
Some notes:
storage-initializer says it is <3.12, so we're using 3.11 here.
we do not have python3.11 poetry, so a. let 'python3.11 -m pip' install poetry b. let that poetry to build a wheel c. install that wheel with 'python3.11 -m pip'
This does use pip to install into the system path. There are lots of deps we already have that we could use, but for now let pip do it.