Make sure placeholders are not drawn twice when activity is destroyed #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaykov
approved these changes
Dec 7, 2022
|
Feel free to merge whenever 👍 |
planarvoid
deleted the
fix/placeholder-behaviour-when-activity-is-destroyed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
When the "Don't keep activities" is turned on and the user leaves the editor and comes back (for example to open a camera and take a photo), the placeholders are redrawn because the
toHtmlis called twice and this triggers themediaLoadingStartedto be called twice. In this PR I'm making sure that doesn't happen.Test
Review
@khaykov
Make sure strings will be translated:
strings.xmlas a part of the integration PR.