Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not remove empty line after a paragraph #1055

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Do not remove empty line after a paragraph #1055

merged 1 commit into from
Aug 4, 2023

Conversation

planarvoid
Copy link
Contributor

Fix

Changes necessary to stop removing empty line between paragraphs.

Test

  1. Use the linked PR to test it

Review

@[USER_NAME]

Make sure strings will be translated:

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

@nbradbury nbradbury self-assigned this Aug 4, 2023
@nbradbury
Copy link
Contributor

:shipit:

@nbradbury nbradbury self-requested a review August 4, 2023 13:22
nbradbury
nbradbury approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is good!

@nbradbury nbradbury merged commit 0dfd4bb into trunk Aug 4, 2023
2 checks passed
@nbradbury nbradbury deleted the fix/do-not-remove-empty-line-between-paragraphs branch August 4, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbradbury nbradbury nbradbury approved these changes

Assignees

@nbradbury nbradbury

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@planarvoid @nbradbury