Bump jsoup to 1.15.3 #1089
Bump jsoup to 1.15.3 #1089
Conversation
Version without reported security vulnerabilities
It was `Element` when jsoup was `1.11.3`
There was a problem hiding this comment.
👋 @wzieba !
I have reviewed and tested this PR as well, everything works as expected, good job! 🌟
I have just a minor (🔍) comment for you to consider. I am going to approve this PR anyway, since none is blocking. I am NOT going to merge this PR yet to give you some time to apply any of my suggestions. However, feel free to ignore them and merge the PR yourself (after fixing the UI test issue).
| .filter { !it.hasText() && it.tagName() == "span" && it.childNodes().size == 0 } | ||
| .forEach { it.remove() } | ||
| val select: Elements = doc.select("*") | ||
| select.filter { element: Element -> |
There was a problem hiding this comment.
Minor (🔍): Why exposing this select local variable if not using it, maybe you had something in mind? 🤔 Consider, reverting it to it's previous form: doc.select("*").filter { element: Element -> ... }
There was a problem hiding this comment.
I thought it'll be more readable, but maybe it's not the case. Inlined in: 5bee1c9
Btw, did we manage to fix the UI test issue @wzieba ? 🤔 |
|
The test happened to be just flaky. I run it locally a few times, it always passed. On CI, I rerun it twice and passed each time. |
|
Oh great, thanks for the confirmation on that! 🙇 😌 |
Version without reported security vulnerabilities
To address https://github.com/wordpress-mobile/WordPress-Android/security/dependabot/91
Test
Smoke test the "code editor" (last button) in AztecDemo app.