Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tracing logging to a single middleware layer #553

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

Dzejkop
Copy link
Contributor

@Dzejkop Dzejkop commented Jul 11, 2023

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation

@Dzejkop Dzejkop requested a review from a team as a code owner July 11, 2023 08:30
@Dzejkop Dzejkop self-assigned this Jul 11, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #553 (5e542fa) into main (5017b7f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 5e542fa differs from pull request most recent head 18336a1. Consider uploading reports for the commit 18336a1 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
- Coverage   55.48%   55.47%   -0.02%     
==========================================
  Files          47       46       -1     
  Lines        9839     9841       +2     
==========================================
  Hits         5459     5459              
- Misses       4380     4382       +2     
Flag Coverage Δ
test 55.47% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/server/mod.rs 17.62% <ø> (-0.58%) ⬇️
src/server/custom_middleware/logging_layer.rs 92.66% <100.00%> (+0.75%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5017b7f...18336a1. Read the comment docs.

@Dzejkop Dzejkop merged commit 24a18c4 into main Jul 11, 2023
5 checks passed
@Dzejkop Dzejkop deleted the Dzejkop/handle-traces branch July 11, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants