Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Config & simplified tasks #674

Merged
merged 17 commits into from
Jan 22, 2024
Merged

Refactor: Config & simplified tasks #674

merged 17 commits into from
Jan 22, 2024

Conversation

Dzejkop
Copy link
Contributor

@Dzejkop Dzejkop commented Jan 17, 2024 •
edited
Loading

Includes:

  1. Deduplication in process_identities
  2. Replaces CLI options with config.rs - now sequencer can be configured with env vars or a config file (or both) - NOTE: env vars will have changed names now
  3. Simplification of tasks (removed a lot of redundant code)
  4. Replaced the parsed config in tests with a type safe config builder
  5. Removed some unused files
  6. Removed a lot of type aliases

@Dzejkop Dzejkop self-assigned this Jan 17, 2024
@Dzejkop Dzejkop requested a review from a team as a code owner January 17, 2024 09:54
0xKitsune
0xKitsune approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@0xKitsune 0xKitsune left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some minor comments.

src/prover/map.rs Show resolved Hide resolved
src/secret.rs Show resolved Hide resolved
src/serde_utils.rs Outdated Show resolved Hide resolved
src/server.rs Show resolved Hide resolved
src/server.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/task_monitor.rs Show resolved Hide resolved
src/utils.rs Show resolved Hide resolved
@Dzejkop Dzejkop merged commit 904af0a into main Jan 22, 2024
5 of 6 checks passed
@Dzejkop Dzejkop deleted the improved-visibility branch January 22, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewoolsey ewoolsey ewoolsey left review comments

@0xKitsune 0xKitsune 0xKitsune approved these changes

Assignees

@Dzejkop Dzejkop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dzejkop @ewoolsey @0xKitsune