Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo for $parent_instance param in RecursiveDataStructureTraverser constructor #422

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

petitphp
Copy link
Contributor

@petitphp petitphp commented Sep 7, 2023

No description provided.

@petitphp petitphp requested a review from a team as a code owner September 7, 2023 08:19
@@ -26,7 +26,7 @@ class RecursiveDataStructureTraverser {
*
* @param mixed $data The data to read/manipulate by reference.
* @param string|int $key The key/property the data belongs to.
* @param static $parent
* @param static $parent_instance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the docblock fully while we're at it.

Suggested change
* @param static $parent_instance
* @param static|null $parent_instance The parent instance of the traverser.

Also, could you adapt the alignment in the docblock? I cannot do that properly via a suggestion...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 1c2e9fe

@danielbachhuber danielbachhuber merged commit 103c335 into wp-cli:main Sep 8, 2023
32 checks passed
@petitphp petitphp deleted the fix/phpdoc-typo branch September 8, 2023 13:36
@petitphp
Copy link
Contributor Author

petitphp commented Sep 8, 2023

Thanks @danielbachhuber !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants