Skip to content

Commit

Permalink
[stable/minio] SEC: Enable random secret and access keys generation b…
Browse files Browse the repository at this point in the history
…y default (#51)

- Random generation of secret and access keys was implemented in f7dc961,
  but not used. All deployments has pre-defined keys by default.
- From 6.0.0 this keys has been weakened.

Signed-off-by: Arano-kai <captcha.is(dot)evil(meov)gmail.com>
  • Loading branch information
Arano-kai committed Oct 28, 2020
1 parent 71e2c6a commit e1913b4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,8 @@ The following table lists the configurable parameters of the MinIO chart and the
| `zones` | Number of zones (applicable only for MinIO distributed mode). | `1` |
| `drivesPerNode` | Number of drives per node (applicable only for MinIO distributed mode). | `1` |
| `existingSecret` | Name of existing secret with access and secret key. | `""` |
| `accessKey` | Default access key (5 to 20 characters) | `YOURACCESSKEY` |
| `secretKey` | Default secret key (8 to 40 characters) | `YOURSECRETKEY` |
| `accessKey` | Default access key (5 to 20 characters) | random 20 chars |
| `secretKey` | Default secret key (8 to 40 characters) | random 40 chars |
| `certsPath` | Default certs path location | `/etc/minio/certs` |
| `configPathmc` | Default config file location for MinIO client - mc | `/etc/minio/mc` |
| `mountPath` | Default mount location for persistent drive | `/export` |
Expand Down
4 changes: 2 additions & 2 deletions minio/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ priorityClassName: ""
## AccessKey and secretKey is generated when not set
## Distributed Minio ref: https://docs.minio.io/docs/distributed-minio-quickstart-guide
##
accessKey: "YOURACCESSKEY"
secretKey: "YOURSECRETKEY"
accessKey: ""
secretKey: ""
certsPath: "/etc/minio/certs/"
configPathmc: "/etc/minio/mc/"
mountPath: "/export"
Expand Down

0 comments on commit e1913b4

Please sign in to comment.