just update the pool configuration if the options changed, because re…

…creating the pool,existed idleconnection, if any, will be dropped without closing
wudalu · May 26, 2018 · 541e894 · 541e894
1 parent c666558
commit 541e894
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/client/rpc_client.go b/client/rpc_client.go
@@ -202,9 +202,12 @@ func (r *rpcClient) Init(opts ...Option) error {
 		o(&r.opts)
 	}
 
-	// recreate the pool if the options changed
+	// update pool configuration if the options changed
 	if size != r.opts.PoolSize || ttl != r.opts.PoolTTL {
-		r.pool = newPool(r.opts.PoolSize, r.opts.PoolTTL)
+		r.pool.Lock()
+		r.pool.size = r.opts.PoolSize
+		r.pool.ttl = int64(r.opts.PoolTTL.Seconds())
+		r.pool.Unlock()
 	}
 
 	return nil