Add minimum time interval and default value to operation polling #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kober32
requested changes
Mar 18, 2024
There was a problem hiding this comment.
Works OK but address the comments please and also 2 additional things:
- update the
func testOperationPolling()test with only 3 counts of loading, raise the timeout interval and remove the 1s parameter, which is ignored anyway. - unrelated, by remove the
let requestStartDate = Date()on the line 409WMTOperationsImpl.swiftplease as it's no longer used
WultraMobileTokenSDK/Operations/Service/WMTOperationsImpl.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#150