Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Romanian language #39

Merged
merged 11 commits into from
Jun 16, 2022
Merged

Added Romanian language #39

merged 11 commits into from
Jun 16, 2022

Conversation

kober32
Copy link
Member

@kober32 kober32 commented May 30, 2022

We need to upgrade gradle files to finish this, as it's not buildable right now (Android).

Also, support for the Russian language cannot be added right now as stated in the original issue #37 as the generator does not support non-ASCII characters.

Words for the Romanian language are taken from the https://github.com/hermitdave/FrequencyWords/.

This fixes #37

@kober32 kober32 changed the title Added Romanian support Added Romanian language May 30, 2022
# Conflicts:
#	Source/src_android/PinCheckerDictionary/build.gradle
#	Source/src_android/PinCheckerDictionaryCzsk/build.gradle
@kober32 kober32 marked this pull request as ready for review June 6, 2022 14:29
@kober32
Copy link
Member Author

kober32 commented Jun 7, 2022

OK, tests are temporarily disabled...

Copy link
Member

@TomasKypta TomasKypta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@kober32 kober32 merged commit ed3d8eb into develop Jun 16, 2022
@kober32 kober32 deleted the 37-ro-ru-suppport branch June 16, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RO and RU languages
2 participants