Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding length of decimalized signatures #451

Closed
petrdvorak opened this issue Jan 21, 2023 · 0 comments
Closed

Allow overriding length of decimalized signatures #451

petrdvorak opened this issue Jan 21, 2023 · 0 comments
Assignees
@petrdvorak
Labels
enhancement

Comments

@petrdvorak
Copy link
Member

Currently, the length of a component is fixed for decimalized signatures. For some use cases, it would be nice to allow overriding the value (i.e., to achieve shorter offline code).
@petrdvorak petrdvorak self-assigned this Jan 21, 2023
petrdvorak added a commit that referenced this issue Jan 21, 2023
@petrdvorak
Fix #451: Allow overriding length of decimalized singatures
50f7943
@petrdvorak petrdvorak changed the title Allow overriding length of decimalized singatures Allow overriding length of decimalized signatures Jan 21, 2023
This was referenced Jan 21, 2023
Closed
Merged
@hvge hvge mentioned this issue Jan 24, 2023
Closed
@hvge hvge mentioned this issue Feb 7, 2023
Closed
jandusil pushed a commit that referenced this issue Dec 6, 2023
@petrdvorak @jandusil
Fix #451: Allow overriding length of decimalized signatures (#452)
faa9a34 
* Fix #451: Allow overriding length of decimalized singatures

* Change code based on code review

* Fix test vector

* Fix JavaDoc

* Add invalid format to exception message

(cherry picked from commit 6d81bf1)
jandusil added a commit that referenced this issue Dec 7, 2023
@jandusil
Fix #451: Allow overriding length of decimalized signatures (#452) (#553
0a1cdca 
)

* Fix #451: Allow overriding length of decimalized singatures
- Change code based on code review
- Fix test vector
- Fix JavaDoc
- Add invalid format to exception message
(cherry picked from commit 6d81bf1)
Co-authored-by: Petr Dvořák <petr@wultra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petrdvorak petrdvorak

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@petrdvorak