Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/grumphp upgrade #54

Merged
merged 13 commits into from
Dec 8, 2020
Merged

Feature/grumphp upgrade #54

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
eb341bb
Grumphp update from 0.16 to 1.0 version
mitrpaka Nov 30, 2020
d766960
Make load() non-returnable. Change service configuration + tag (confi…
mitrpaka Nov 30, 2020
311366c
Updated construction. Added getConfig() and immutable withConfig() me…
mitrpaka Nov 30, 2020
a170c5c
Replaced getConfiguration() method by the getConfig() method
mitrpaka Nov 30, 2020
5bf39c7
Make getConfigurableOptions() static. Added getConfig() and immutable…
mitrpaka Nov 30, 2020
e1eee78
Updated construction. Replaced getConfiguration() method by the getCo…
mitrpaka Nov 30, 2020
cbfb872
Updated tasks. Replaced getConfiguration() method by the getConfig() …
mitrpaka Nov 30, 2020
13798d2
Updated tests
mitrpaka Nov 30, 2020
bb418fd
Put tasks and other grumphp related configuration under grumphp
mitrpaka Nov 30, 2020
61a3db6
Fixed phpcs warning and error notifications
mitrpaka Nov 30, 2020
0ec2b23
Renamed PhpstanCheckDeprecationTask to PhpStanTask
mitrpaka Dec 8, 2020
d840632
Use Coding Standard and ECS 8.3. Use ecs.php for ECS. Include Cogniti…
mitrpaka Dec 8, 2020
9bcce73
Use ecs-drupal 1.0 and above
guncha25 Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make load() non-returnable. Change service configuration + tag (confi… 
…g -> task)
  • Loading branch information
@mitrpaka
mitrpaka committed Nov 30, 2020
commit d76696056f53cf1cbcb713cf73ba5a08a5520ac0
16 changes: 6 additions & 10 deletions src/Task/AbstractExternalExtensionLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

use GrumPHP\Extension\ExtensionInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Definition;
use Symfony\Component\DependencyInjection\Reference;
use Symfony\Component\Yaml\Yaml;

Expand Down Expand Up @@ -57,17 +56,14 @@ public function __construct() {
/**
* {@inheritdoc}
*/
public function load(ContainerBuilder $container): Definition {
public function load(ContainerBuilder $container): void {
$task = $container->register('task.' . $this->name, $this->class);
$task->addTag('grumphp.task', ['config' => $this->name]);
if (empty($this->arguments)) {
return $task;
if (!empty($this->arguments)) {
foreach ($this->arguments as $argument) {
$task->addArgument(new Reference($argument));
}
}
foreach ($this->arguments as $argument) {
$task->addArgument(new Reference($argument));
}

return $task;
$task->addTag('grumphp.task', ['task' => $this->name]);
}

}