feat: Use @types/chrome for config manifest type
#969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #969 +/- ##
==========================================
- Coverage 81.96% 81.71% -0.26%
==========================================
Files 125 125
Lines 6605 6605
Branches 1099 1099
==========================================
- Hits 5414 5397 -17
- Misses 1177 1194 +17
Partials 14 14 ☔ View full report in Codecov by Sentry. |
aklinker1
changed the title
@types/chrome for config manifest type@types/chrome for config manifest type
aklinker1
changed the title
@types/chrome for config manifest type@types/chrome for config manifest type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #521
Properties like
key, which were missing before, are now typed properly.I am NOT marking this as a breaking change because the only change is to types... the runtime behavior hasn't changed. If this breaks peoples types, I'll fix them by adding custom typings.