Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update details column for gc history #164

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

AllForNothing
Copy link

1.Fixes goharbor#19038

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

1.Fixes goharbor#19038

Signed-off-by: AllForNothing <sshijun@vmware.com>
@sonatype-lift
Copy link

sonatype-lift bot commented Jul 31, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #164 (47e566d) into fix-19040 (84a1317) will decrease coverage by 25.75%.
Report is 1 commits behind head on fix-19040.
The diff coverage is 40.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           fix-19040     #164       +/-   ##
==============================================
- Coverage      70.58%   44.83%   -25.75%     
==============================================
  Files            748      244      -504     
  Lines          95341    13390    -81951     
  Branches           0     2748     +2748     
==============================================
- Hits           67292     6003    -61289     
+ Misses         24423     7083    -17340     
+ Partials        3626      304     -3322     
Flag Coverage Δ
unittests 44.83% <40.00%> (-25.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...-job/gc-page/gc/gc-history/gc-history.component.ts 35.23% <40.00%> (ø)

... and 991 files with indirect coverage changes

@wy65701436 wy65701436 merged commit 16f2899 into wy65701436:fix-19040 Jul 31, 2023
8 of 9 checks passed
AllForNothing added a commit that referenced this pull request Jul 31, 2023
1.Fixes goharbor#19038

Signed-off-by: AllForNothing <sshijun@vmware.com>
wy65701436 added a commit that referenced this pull request Jul 31, 2023
* add details for gc dry-run

fixes 19040
Gives the make details for the dry-run

Signed-off-by: wang yan <wangyan@vmware.com>

* Update details column for gc history (#164)

1.Fixes goharbor#19038

Signed-off-by: AllForNothing <sshijun@vmware.com>

---------

Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: AllForNothing <sshijun@vmware.com>
Co-authored-by: Shijun Sun <30999793+AllForNothing@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants