Minor code comment/alignment changing

x64dbg · Nov 1, 2015 · 28a8c86 · 28a8c86
1 parent 6d976a4
commit 28a8c86
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 13 deletions.
diff --git a/Operand.cpp b/Operand.cpp
@@ -38,7 +38,7 @@ bool HandleSegSelectorOperand(XEDPARSE* Parse, const char* Value, InstOperand* O
     // Copy the offset
     strcpy(offset, strrchr(Value, ':') + 1);
 
-    // The segment selector is always a number
+    // The segment selector is always a number from 0 to 0xFFFF
     if(strlen(selector) > 0)
     {
         ULONGLONG selVal = 0;

diff --git a/Operand.h b/Operand.h
@@ -2,12 +2,12 @@
 
 enum OPERAND_TYPE
 {
-    OPERAND_INVALID,
-    OPERAND_REG,
-    OPERAND_IMM,
-    // OPERAND_IMM1,
-    OPERAND_MEM,
-    OPERAND_SEGSEL,
+    OPERAND_INVALID,    // Bad operand
+    OPERAND_REG,        // Register
+    OPERAND_IMM,        // Immediate
+    // OPERAND_IMM1,    // Immediate #2 (See ENTER instruction)
+    OPERAND_MEM,        // Memory
+    OPERAND_SEGSEL,     // Segment selector (Immediate)
 };
 
 struct InstOperand
@@ -48,11 +48,11 @@ struct InstOperand
             bool            Scale;
             xed_uint64_t    ScaleVal;
 
-            bool    Base;
-            REG     BaseVal;
+            bool            Base;
+            REG             BaseVal;
 
-            bool    Index;
-            REG     IndexVal;
+            bool            Index;
+            REG             IndexVal;
         } Mem;
 
         struct

diff --git a/Prefix.h b/Prefix.h
@@ -2,7 +2,7 @@
 
 enum PREFIX
 {
-    PREFIX_NONE,
+    PREFIX_NONE,    // NO PREFIX
     PREFIX_LOCK,    // LOCK F0
     PREFIX_REP,     // REP/REPE/REPZ F3
     PREFIX_REPNEZ,  // REPNE/REPNZ F2

diff --git a/parsetest.cpp b/parsetest.cpp
@@ -53,7 +53,7 @@ void OperandToString(char* Buffer, InstOperand* Operand)
 
 void InstructionToString(char* Buffer, Inst* Instruction)
 {
-    // Add the prefix is there was one
+    // Add the prefix if there was one
     if(Instruction->Prefix != PREFIX_NONE)
     {
         strcat(Buffer, PrefixToString(Instruction->Prefix));