-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom row templates don't work in IE #138
Comments
I think that these polyfills aren't working maybe cause the object's type are not set correctly. The method includes is on a string context and the method entries is on an object's context. Does this makes any sense or I am wrong? |
This is the template I am using for this
|
Digging more deeper into this I found 2 things on this on IE11. If I change this The props data gets rendered correctly. So vuejs directives like v-text and v-html aren't working as expected on slots on IE11. The second thing is that I found that props aren't being inserted in the elements. Please take a look of this screenshot in IE11. There is no I don't know if there anyone facing this problem as me but anyone who gets into any version of IE maybe fall in the error as me. I have been 2 days trying to fix this but still can't find any solution. Please help @xaksis 😢 |
@arivera12 sorry Ive been sick last few days. This is happening because IE doesn't allow tag inside tables: vuejs/vue#3028 |
@xaksis I have been sick too these days 😢 there is something in the air that everyone is getting sick I got my kids and my brother sick too. |
I think you should state that for using this plugin with IE include the 2 polyfills I added here so this plugin can work on IE for other users of this plugin. |
@xaksis any update on this? |
@arivera12 i was able to solve it by adding babel-polyfill to my projects. Just install babel-polyfill entry: {
app: [
'babel-polyfill',
'./src/main.js'
]
}, (don't forget to remove the earlier polyfills that you added, babel takes care of all those) |
@xaksis Babel-polyfill at least makes the table render but not to render correctly on IE. IE still doesn't render correctly take a look: IE doesn't put Please reopen this issue is not resolved, IE doesn't work yet. Did you really test this on IE? |
v-text and v-html directives aren't even working on the template scope they just render blank on IE. |
@arivera12 can you try https://xaksis.github.io/vue-good-demos/#/dynamic-table on your browser and paste a screenshot here? |
The demo site works as expected. The problem that I have is that on my project this doesn't render correctly. I updated vuejs, this plugin and still doesn't work.
The This is what it gets rendered using this code. This is what is inside the table row I saw for a moment that your example uses the mustache tag for example {{ props.row.NeedAreaOrTrainingDescription }} and at least data gets displayed but still gets rendered out of the using v-text works on chrome and other browsers without any problems but it seems that IE doesn't understand the v-text directive don't know what is wrong with this on IE. @xaksis is there anything wrong with my source? |
Can you share vue-good-table code that is being used on the demo to see what's difference with my source? Thanks. |
@arivera12 if you weren't able to fix your build... try updating to v1.18.2 I have added the polyfills to the built plugin so hopefully you don't need to do anything else. the source to vue-good-demo is available on github: https://github.com/xaksis/vue-good-demos |
Hi bro, i really need your help. i just create a new project with command npm install --global vue-cli and them vue init webpack my-project, them import the plugin and works great, but when a test it on IE10 it din't work. just launch a syntax error. |
@leonardochen30 Use latest version of vue-good-table. I am still having the same rendering issue on the tables on IE which td elements doesn't gets render. Please let me know if you have the same problem as me so we can reopen this thread. |
Hi, i use the last version of vue-good-table yesterday with npm. |
On IE11 works great and chromiun based browser, on IE10 not load. |
@leonardochen30 can you please share with me your vuejs version and the working sample you are using for vue-good-table that works on IE?. I don't know why code doesn't work on IE11. Thanks in advance. |
I resolve the issue adding this resolve('node_modules/vue-good-table/src') to the babel-loader include section. |
I am not using babel or webpack either. Just wanted a working template of vue-good-table.... |
@arivera12 i think i was finally able to pinpoint what was going on. package.json had module entry pointing to the source file. so if you were using any kind of bundler, it would use the source file instead of the polyfilled umd version of the plugin. In version 1.18.6, I have:
I have tested on IE11 and everything seems to be in order. Try again with the new version of the library and let me know what you see. |
@xaksis I just tried the new build and I am still having the same issue... |
@xaksis Please try this example I am putting here so you can see for your self that templates doesn't work on IE. This works on IE.
This doesn't work on IE11
Slot templates doesn't work on IE. Even v-text and v-html directives on templates aren't working on IE. |
@arivera12 are you using it via CDN? I Try your example in IE10 and IE11 and it worked correctly. I do use a project via vue-cli with webpack and babel. |
@leonardochen30 please try the second example that I say it doesn't work first and confirm that this is working or not. I have all my files locally. I am using vue-good-table latest Try the example with the template slot and see if its working or not. |
@leonardochen30
|
@leonardochen30 |
Hi bro, attached a demo project. Execute: npm install |
@leonardochen30 |
I couldn't test it or integrate this into my project... So sad for me 😢 |
What error gave to you? |
I am not using vue-loader or webpack or any module bundler. I am just using the https://github.com/xaksis/vue-good-table/blob/master/dist/vue-good-table.min.js into my project and thats all. This seems to be working on the module bundle but the standalone lib doesn't work on IE. If you just add the vue.min.js & vue-good-table.min.js without any module bundle you will run into my problem. This plugin using the vue-good-table.min.js as standalone lib work everywhere but no on IE. I am thinking we are on different channels regarding on this based the way we are integrating this on the project. Can you try a new clean project ONLY without any module bundle using vue.js & vue-good-table.js and a sample index.html and adding the static files into it? If this works for you just don't know what in hell is going on!!!!! There are differences in terms of JS using the module bundle and the standalone installation. |
@arivera12 Did you figure it out or find a fix for it yet? I've encountered the same issue with |
@khe817 how are you incorporating the plugin? what version are you using? |
I did the same thing @arivera12 did here in my project:
To clarify, I include I am using the newest versions for When I try to use
|
I'm going to re-open this issue. This is only happening in the case of custom template because IE doens't allow anything inside tr other than td or th. So the I'll update here when the fix is part of the alpha. |
@xaksis thanks I will wait for this! |
alright I think the alpha is finally ready for IE There are quite a few changes, so make sure you read the upgrade guide: You can read the full documentation here: If you're using the CDN version, these links will get you the latest alpha |
@xaksis I have tested it in my project. It works beautifully in all major browsers (firefox, chrome, Edge, IE 11). There is a small bug in IE 11 and Edge though:
There is a small bug in all browsers:
As opposed to what we want:
I also got this error in console log, but it does not affect anything as far as I am aware:
|
💥 ! good news that this is now working in IE. and @khe817 thank you so much for spending time testing the new version out!! I'll make fixes to this and update once they're in. |
@khe817 v2.0.0-alpha.7 should now have the fix for
|
@xaksis v2.0.0-alpha.7 works as expected. Another note for the pagination bug in IE 11 and Edge. If I specify |
closing. |
This plugin doesnt work on IE11.
I added the polyfills for includes and entries to fix this and still doesn't work.
Take a look of these threads in stackoverflow.
Link Includes
Link Entries
Any solution for this?
The text was updated successfully, but these errors were encountered: