Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slot for table footer #522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

p0psicles
Copy link
Collaborator

@p0psicles p0psicles commented Mar 13, 2019

This can be used to add a footer when using the grouped-table option.

This should address #518
image

This can be used to add a footer when using the grouped-table option.
<tr>
<td colspan="100%">
<span>
The {{props.rows.filter(x => x.count === Math.max.apply(Math, props.rows.map(row => { return row.count;})))[0].name}} is the animal with the highest count: {{props.rows.filter(x => x.count === Math.max.apply(Math, props.rows.map(row => { return row.count;})))[0].count}}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for demonstration puposes

@xaksis
Copy link
Owner

xaksis commented Apr 8, 2019

Have you tested this in IE? table tags inside a template that is then repeated in a v-for gets removed by IE before it is rendered: #138 for reference.

can also look up some issues that explain it in detail: https://stackoverflow.com/questions/51021827/vuejs-in-ie-11-template-wrapper-for-tr-not-working-works-in-edge-and-chrome

@p0psicles
Copy link
Collaborator Author

@xaksis Sorry for not replying in a long time.
Are you sure you want to support IE11? I mean at some point we also stopped supporting IE6 and IE8?
I can try to get it to work with IE11. Would you be willing to merge it, if I get that fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants