Remove debounce on dropdown column filter #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheJaredWilcurt
changed the title
TheJaredWilcurt
approved these changes
Jan 22, 2021
There was a problem hiding this comment.
@xaksis This worked for me locally. Unless you see any potential conflicts with existing code, I think this is good to merge/release.
|
@xaksis can we get a new release with this code change? It's been about a month since the last release. |
This was referenced Mar 12, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #732.
Drop downs should now use
updateFiltersImmediatelyin order to avoid the setTimeout.This also fixes the console errors when running locally using
npm run dev